-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed warnings - strict-prototypes #800
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
Let's put this on the queue to merge after the freeze is lifted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Errors on arch64 are related with a bug in gcc, in particular in mimick mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf' |
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 2579950)
There are new warnings on CI related with this compiler option
strict-prototypes
https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/