Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to disable workaround for dependency groups #3

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 24, 2024

See ros-infrastructure/catkin_pkg#369

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Scott K Logan <logans@cottsay.net>
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one nitpick is that this change loses the information about which group each package is being unrolled from. But a context-having reviewer would likely be able to spot or guess at this.

@cottsay
Copy link
Member Author

cottsay commented May 31, 2024

My one nitpick is that this change loses the information about which group each package is being unrolled from. But a context-having reviewer would likely be able to spot or guess at this.

If you look closely at the rosidl_core_generators change, you can see that the clustering was actually wrong. rosidl_typesupport_c is not a member of rosidl_typesupport_c_packages (etc).

Additionally, rosidl_generator_type_description is missing from the curated list for rosidl_generator_packages.

I point this out only to demonstrate that curating this information manually is prone to error and rot, so I suggest that we curate as little information as is necessary to work around the lack of groups support.

@cottsay cottsay merged commit d56e5e1 into rolling Jun 5, 2024
2 checks passed
@cottsay cottsay deleted the cottsay/groups-workaround branch June 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants