fixes acl cat bug

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri · Oct 9, 2024 · ca53975 · ca53975
1 parent cd8de09
commit ca53975
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/acl.c b/src/acl.c
@@ -2760,7 +2760,6 @@ void aclCatWithFlags(client *c, dict *commands, uint64_t cflag, int *arraylen) {
 
     while ((de = dictNext(di)) != NULL) {
         struct serverCommand *cmd = dictGetVal(de);
-        if (cmd->flags & CMD_MODULE) continue;
         if (cmd->acl_categories & cflag) {
             addReplyBulkCBuffer(c, cmd->fullname, sdslen(cmd->fullname));
             (*arraylen)++;

diff --git a/tests/unit/moduleapi/aclcheck.tcl b/tests/unit/moduleapi/aclcheck.tcl
@@ -143,6 +143,11 @@ start_server {tags {"modules acl"}} {
         assert_equal [r acl DRYRUN j8 aclcheck.module.command.test.add.new.aclcategories] OK
     }
 
+    test {test if ACL CAT output for the new category is correct} {
+        set cmds_in_cat [r ACL CAT foocategory]
+        assert {$cmds_in_cat eq {aclcheck.module.command.test.add.new.aclcategories}}
+    }
+
     test {test permission compaction and simplification for categories added by a module} {
         r acl SETUSER j9 on >password -@all +@foocategory -@foocategory
         catch {r ACL GETUSER j9} res