Coverity Scan fixes

rouault · Nov 26, 2024 · 90c910b · 90c910b
1 parent 950cd2a
commit 90c910b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/ogr/ogrsf_frmts/geojson/libjson/json_util.c b/ogr/ogrsf_frmts/geojson/libjson/json_util.c
@@ -204,6 +204,7 @@ static int _json_object_to_fd(int fd, struct json_object *obj, int flags, const
 	wpos = 0;
 	while (wpos < wsize)
 	{
+		/* coverity[overflow_sink] */
 		if ((ret = write(fd, json_str + wpos, wsize - wpos)) < 0)
 		{
 			_json_c_set_last_err("json_object_to_file: error writing file %s: %s\n",

diff --git a/port/cpl_spawn.cpp b/port/cpl_spawn.cpp
@@ -458,6 +458,7 @@ int CPLPipeRead(CPL_FILE_HANDLE fin, void *data, int length)
     {
         while (true)
         {
+            // coverity[overflow_sink]
             const ssize_t n = read(fin, pabyData, nRemain);
             if (n < 0)
             {
@@ -499,6 +500,7 @@ int CPLPipeWrite(CPL_FILE_HANDLE fout, const void *data, int length)
     {
         while (true)
         {
+            // coverity[overflow_sink]
             const ssize_t n = write(fout, pabyData, nRemain);
             if (n < 0)
             {

diff --git a/port/cpl_vsil_curl.cpp b/port/cpl_vsil_curl.cpp
@@ -1373,7 +1373,7 @@ vsi_l_offset VSICurlHandle::GetFileSizeOrHeaders(bool bSetError,
                             if (osValue.size() >= 2 && osValue.front() == '"' &&
                                 osValue.back() == '"')
                                 osValue = osValue.substr(1, osValue.size() - 2);
-                            oFileProp.ETag = osValue;
+                            oFileProp.ETag = std::move(osValue);
                         }
 
                         // Azure Data Lake Storage