Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OGRCurvePolygon::isRingCorrectType #60

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add OGRCurvePolygon::isRingCorrectType #60

merged 2 commits into from
Oct 10, 2024

Conversation

dbaston
Copy link

@dbaston dbaston commented Oct 10, 2024

For me this is a little more clear than the bOnlyType flag -- I had to read the implementations to understand what that flag was doing.

Feel free to keep or discard as you like. (Tests could probably be kept regardless)

Unrelated, but it seems odd that CurvePolygon will not accept a LinearRing ring.

@dbaston dbaston mentioned this pull request Oct 10, 2024
Merged
@rouault rouault merged commit 4d81cd1 into rouault:ogrgeometry_cleanup Oct 10, 2024
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbaston @rouault