Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving user a chance to use the original color of the icon, instead of always use a color filter #358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KyleXie
Copy link

@KyleXie KyleXie commented Jul 14, 2016

Some times, we would like to use the original image as the inactive tab icon, say, I have a semitransparent icon, after setColorFilter, it turns to opacity, that's not what I want, so I fixed it like this, if there's no FixedInactiveIconColor, we just clear the filter for unselected tab. Hope this helps.

@raviteja786143
Copy link

Yes please. I have one icon with all rainbow colors but due to tintable imageview its impossible for me render original image on bottom bar

@MiralDesai
Copy link

MiralDesai commented Aug 12, 2016

Does this need to be merged in before we can use it? This is really frustrating. Can't change text color, can't use icons that have designed for me. White on white is pointless. I set my own TextAppearance style but of course it's still getting overriden by the library and using white.

@roughike roughike added the v1 label Jan 10, 2017
@yombunker
Copy link
Collaborator

@KyleXie @MiralDesai @raviteja786143 is this still a thing you guys need even with the latest version?

@yombunker yombunker self-assigned this Mar 24, 2017
@MiralDesai
Copy link

I'm no longer using this library so can't really say. I would say it's a good feature to have though, to allow developers to put their app's theme on the bottom bar.

@KyleXie
Copy link
Author

KyleXie commented Apr 17, 2017

@yombunker sorry for late response, if someone already fixed this, please just close this PR. I'm not working on that project any more, so I'm not sure if the latest version works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants