Do not add user site-packages directory to sys.path (RHEL-26646) #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
force-pushed
the
fix/dont_add_usr_local_python_modules
branch
2 times, most recently
from
8aa5298
to
ab22cb9
Compare
ppisar
reviewed
Apr 4, 2024
Current directory is controlled by -P option. Not -s option. Remove these words from the commit message. |
Probably not just the current directory. Python Packaging Guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_shebangs states (I'll comment the code): Anyway, I copied the text from the Python Packaging Guidelines and they probably have a mistake in the description (I found another error there already yesterday). |
Adds `-s` to shebang lines. The `-s` flag ensures that the user’s Python packages (e.g. installed by pip install --user) don’t interfere with the RPM installed software. According to Fedora Python Packaging Guidelines, the flag is added using `%py3_shebang_fix` macro. Note: DNF supports plugins. There is a risk that the change will break a custom plugins that require something from PIP. Therefore, the change is only in the .spec file and is only allowed for Fedora >= 41 and RHEL >= 10.
jrohel
force-pushed
the
fix/dont_add_usr_local_python_modules
branch
from
ab22cb9
to
0a90976
Compare
ppisar
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-sto shebang lines.The
-sflag ensures that the user’s Python packages (e.g. installed bypip install --user) don’t interfere with the RPM installed software.According to Fedora Python Packaging Guidelines, the flag is added using
%py3_shebang_fixmacro.Note:
DNF supports plugins. There is a risk that the change will break a custom plugins that require something from PIP.
Therefore, the change is only in the .spec file and is only allowed for Fedora >= 41 and RHEL >= 10.