Fix: No traceback when Python interpreter is running with -P, allow -P in shebang lines
#2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was code in dnf and dnf-automatic to support running them from the git tree. This was a developer-oriented hack that should not exist in production code. It assumed that when running an installed dnf, the `sys.path[0]` contains `/usr/bin`. If not, it overwrites the contents of `sys.path[0]`. This is a problem when running the Python interpreter with the `-P` parameter (meaning: Don't automatically prepend a potentially unsafe path to sys.path such as the current directory, the script's directory or an empty string.) The fix removes this developer-oriented hack. Developers should instead set PYTHONPATH in the environment.
There was a bug in dnf and dnf-automatic that caused traceback when running the Python interpreter with the `-P` argument. Since the bug has been fixed, the `-P` argument can be used.
ppisar
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
The code looks good. Though tests in testing farm were not executed because of "package dnf-data-4.20.0-1.20240426113905572340.pr2089.3.gc9da8e61.fc41.noarch from @commandline requires /etc/dnf/dnf.conf, but none of the providers can be installed". The failure is probably unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2078