rhel-9.5: automatic: Use add_security_filters, not _update_security_filters #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream commit: 0b4b8cc Resolves: https://issues.redhat.com/browse/RHEL-21874 It seems that these two approaches for selecting security updates sometimes disagree. The regular `dnf update` command uses base.add_security_filters to select security updates, so dnf-automatic should do the same.
evan-goode
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM. I tested that dnf-automatic still applied a simple security update correctly on RHEL 9.4.
However, @bajertom and I have been unable to reproduce the original bug described in https://issues.redhat.com/browse/RHEL-21874. When I implemented this fix, I was able to reproduce the bug, and the fix worked, but something must have changed in the RHEL repositories that caused my reproducer to stop working.
We both have already spent a lot of time trying to find the root cause, so it may not be worth continuing to investigate. Regardless, this is a simple patch and the behavior of dnf and dnf-automatic with respect to security updates will now be unified.
|
Thanks for the review and the details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit: 0b4b8cc
Resolves: https://issues.redhat.com/browse/RHEL-21874
@evan-goode, could you please review this rhel-9.5 backport of your commit?