-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progressive galib/update readme.rst #2170
base: master
Are you sure you want to change the base?
Progressive galib/update readme.rst #2170
Conversation
…and included a link to the latest DNF5 repository. type: enhancement resolves: rpm-software-management#2154 related: rpm-software-management#2153 msg: Updated `readme.rst` to clarify that the repository is for DNF4 and included a link to the latest DNF5 repository. type: enhancement resolves: rpm-software-management#2154 related: rpm-software-management#2153
…and included a link to the latest DNF5 repository. type: enhancement resolves: rpm-software-management#2154 related: rpm-software-management#2153 msg: Updated `readme.rst` to clarify that the repository is for DNF4 and included a link to the latest DNF5 repository. type: enhancement resolves: rpm-software-management#2154 related: rpm-software-management#2153
README.rst
Outdated
############### | ||
|
||
================================================================================================================================================================================================== | ||
⚠️ **Notice:** This repository is for **DNF4** only For the current DNF version (DNF5), visit `https://github.com/rpm-software-management/dnf5` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a period missing between "only For"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the link looks a bit odd here, maybe shorten the link text to rpm-software-management/dnf5
or rephrase it compeletely, e.g. "The current DNF version is DNF 5
." or "The current DNF version 5 has its own repository
" (With the ticked
words as the same link of course.)
But these are just suggestions to make it look nicer, your current PR would also be good enough for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
english is not my first language can you rewrite that bit for me ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
english is not my first language can you rewrite that bit for me ?
ohh i see the mistake now, no need to write, i am doing it myself
|
||
.. image:: https://raw.githubusercontent.com/rpm-software-management/dnf/gh-pages/logos/DNF_logo.png | ||
|
||
Dandified YUM (DNF) is the next upcoming major version of `YUM <http://yum.baseurl.org/>`_. It does package management using `RPM <http://rpm.org/>`_, `libsolv <https://github.com/openSUSE/libsolv>`_ and `hawkey <https://github.com/rpm-software-management/hawkey>`_ libraries. For metadata handling and package downloads it utilizes `librepo <https://github.com/tojaj/librepo>`_. To process and effectively handle the comps data it uses `libcomps <https://github.com/midnightercz/libcomps>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was quite outdated, good catch!
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me, thanks! But I am not a maintainer / reviewer for this project, so hopefully they will agree and merge this 😉
############### | ||
|
||
================================================================================================================================================================================================== | ||
⚠️ **Notice:** This repository is for **DNF4** only. The current DNF version (DNF5), has its `own repo <https://github.com/rpm-software-management/dnf5>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also not an expert in English but I think the comma after ..version (DNF5), has..
should not be there -> ..version (DNF5) has..
.
Otherwise I think it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, sorry I missed that in my first review.
I revised the
readme.rst
file to accurately reflect that the repository pertains to DNF4, addressing potential confusion with latest dnf by adding a notice and a link directing users to the repository for DNF5.These changes aim to improve documentation clarity and user navigation. This update resolves issue [#2154](#2154) .
= changelog =
msg: Updated
readme.rst
to clarify that the repository is for DNF4 and included a link to the latest DNF5 repository.type: enhancement
resolves: #2154
related: #2154