doc: --disableexcludepkgs=all doesn't affect just file configuration
#2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are unrelated, in my previous PR I disabled the wrong dnf automatic test here is a fix: rpm-software-management/ci-dnf-stack#1607 There are also unrelated rawhide copr failing tests, I made an issue for that here: rpm-software-management/ci-dnf-stack#1606 |
m-blaha
reviewed
Dec 13, 2024
doc/command_ref.rst
Outdated
| @@ -167,7 +167,7 @@ Options | |||
| ``--disableexcludes=[all|main|<repoid>], --disableexcludepkgs=[all|main|<repoid>]`` | |||
| Disable the configuration file excludes. Takes one of the following three options: | |||
|
|
|||
| * ``all``, disables all configuration file excludes | |||
| * ``all``, disables all configuration excludes and includes | |||
There was a problem hiding this comment.
Would it make sense to specify that --disableexcludes operates on both excludepkgs and includepkgs before this bullet list? I believe it disables both even for main and repoid values.
There was a problem hiding this comment.
That is a good point.
I have updated the whole section, let me know what you think.
The option `--disableexcludepkgs=all` disables all configuration includes and excludes including packages specified on the commandline via `--exclude=`, `-x=`, the deprecated `--excludepkgs=` and file configuration via `--excludepkgs=`, `--includepkgs=`.
kontura
force-pushed
the
disable_excludes
branch
from
eeb8467 to
d16885b
Compare
m-blaha
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
--disableexcludepkgs=alldisables all configuration includes and excludes including packages specified on the commandline via--exclude=,-x=, the deprecated--excludepkgs=and file configuration via--excludepkgs=,--includepkgs=.https://issues.redhat.com/browse/RHEL-28779 (Once merged I will also backport to the 9.6 branch).