Fix for Antivirus Software block #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this is necessary, but it seems worth doing.
Some antivirus programs override CreateProcess() and run the child process initially in a sandbox, then after deciding the process is OK, they run it again for real. The initial instance of winpty-agent.exe connects to libwinpty's control pipe, then when the actual agent process starts later, it can't connect to the pipe because the pipe is in a disconnected/broken state. Work around the problem by creating multiple instances of the control pipe in libwinpty, then waiting on any of them to connect. An error on one pipe is logged to trace() but otherwise ignored as long as one of the pipes eventually connects. The error isn't reported until the agent dies or the connection has timed out. In practice, the initial sandbox connection's ConnectNamedPipe operation will probably succeed, but its child PID will be wrong, so this function quietly ignores verifyPipeClientPid failures (as long as one pipe succeeds). Fixes #142
The __attribute__((used)) annotation breaks the MSVC build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to: #142