Fix error in ModuleDependencies

Refs #1067

lib/credo/check/refactor/module_dependencies.ex

@@ -35,7 +35,7 @@ defmodule Credo.Check.Refactor.ModuleDependencies do
 
     max_deps = Params.get(params, :max_deps, __MODULE__)
     dependency_namespaces = Params.get(params, :dependency_namespaces, __MODULE__)
-    excluded_namespaces = Params.get(params, :excluded_namespaces, __MODULE__)
+    excluded_namespaces = params |> Params.get(:excluded_namespaces, __MODULE__) |> Enum.map(&to_string/1)
     excluded_paths = Params.get(params, :excluded_paths, __MODULE__)
 
     case ignore_path?(source_file.filename, excluded_paths) do

test/credo/check/refactor/module_dependencies_test.exs

@@ -31,11 +31,7 @@ defmodule Credo.Check.Refactor.ModuleDependenciesTest do
     |> refute_issues()
   end
 
-  #
-  # cases raising issues
-  #
-
-  test "it should report a violation" do
+  test "it should NOT report a violation on non-umbrella test path" do
     """
     defmodule CredoSampleModule do
       def some_function() do
@@ -55,12 +51,12 @@ defmodule Credo.Check.Refactor.ModuleDependenciesTest do
       end
     end
     """
-    |> to_source_file
+    |> to_source_file("test/foo/my_test.exs")
     |> run_check(@described_check)
-    |> assert_issue()
+    |> refute_issues()
   end
 
-  test "it should not report a violation on non-umbrella test path" do
+  test "it should NOT report a violation on umbrella test path" do
     """
     defmodule CredoSampleModule do
       def some_function() do
@@ -80,12 +76,12 @@ defmodule Credo.Check.Refactor.ModuleDependenciesTest do
       end
     end
     """
-    |> to_source_file("test/foo/my_test.exs")
+    |> to_source_file("apps/foo/test/foo/my_test.exs")
     |> run_check(@described_check)
     |> refute_issues()
   end
 
-  test "it should not report a violation on umbrella test path" do
+  test "it should NOT report a violation with excluded namespaces" do
     """
     defmodule CredoSampleModule do
       def some_function() do
@@ -105,8 +101,43 @@ defmodule Credo.Check.Refactor.ModuleDependenciesTest do
       end
     end
     """
-    |> to_source_file("apps/foo/test/foo/my_test.exs")
-    |> run_check(@described_check)
+    |> to_source_file
+    |> run_check(@described_check,
+      excluded_namespaces: [
+        DateTime,
+        Kernel,
+        GenServer
+      ]
+    )
     |> refute_issues()
   end
+
+  #
+  # cases raising issues
+  #
+
+  test "it should report a violation" do
+    """
+    defmodule CredoSampleModule do
+      def some_function() do
+        [
+          DateTime,
+          Kernel,
+          GenServer,
+          GenEvent,
+          File,
+          Time,
+          IO,
+          Logger,
+          URI,
+          Path,
+          String
+        ]
+      end
+    end
+    """
+    |> to_source_file
+    |> run_check(@described_check)
+    |> assert_issue()
+  end
 end