Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap v4 final #2233

Draft
wants to merge 214 commits into
base: master
Choose a base branch
from

Merge pull request #2797 from rsksmart/vovchyk/snap/config-adjustment

230fe0e
Select commit
Loading
Failed to load commit list.
Draft

Snap v4 final #2233

Merge pull request #2797 from rsksmart/vovchyk/snap/config-adjustment
230fe0e
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Oct 25, 2024 in 3s

8 new alerts

New alerts in code changed by this pull request

  • 8 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 156 in rskj-core/src/main/java/co/rsk/net/SnapshotProcessor.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'ignoredRequestMessage' is never used.

Check notice on line 46 in rskj-core/src/main/java/co/rsk/net/messages/SnapBlocksRequestMessage.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'blockFactory' is never used.

Check notice on line 64 in rskj-core/src/main/java/co/rsk/net/messages/SnapStateChunkRequestMessage.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'blockFactory' is never used.

Check notice on line 76 in rskj-core/src/main/java/co/rsk/net/messages/SnapStateChunkResponseMessage.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'blockFactory' is never used.

Check notice on line 111 in rskj-core/src/main/java/co/rsk/net/sync/PeersInformation.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
SnapshotPeersInformation.getOrRegisterPeer
Loading
; it is advisable to add an Override annotation.

Check notice on line 222 in rskj-core/src/main/java/co/rsk/net/sync/SnapSyncState.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getAllNodes exposes the internal representation stored in field allNodes. The value may be modified
after this call to getAllNodes
Loading
.

Check notice on line 242 in rskj-core/src/main/java/co/rsk/net/sync/SnapSyncState.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getSnapStateChunkQueue exposes the internal representation stored in field snapStateChunkQueue. The value may be modified
after this call to getSnapStateChunkQueue
Loading
.

Check notice on line 246 in rskj-core/src/main/java/co/rsk/net/sync/SnapSyncState.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getChunkTaskQueue exposes the internal representation stored in field chunkTaskQueue. The value may be modified
after this call to getChunkTaskQueue
Loading
.