Updating smell test #2836
Merged
Updating smell test #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
fmacleal
force-pushed
the
add-gradle-sonar-scanner
branch
from
98efb00
to
dacf4ba
Compare
fmacleal
reviewed
Nov 4, 2024
rskj-core/src/main/java/co/rsk/rpc/modules/debug/DebugModuleImpl.java
Outdated
Show resolved
Hide resolved
fmacleal
force-pushed
the
add-gradle-sonar-scanner
branch
from
dacf4ba
to
ecb810d
Compare
fmacleal
previously approved these changes
Nov 5, 2024
rskj-core/src/main/java/co/rsk/rpc/modules/debug/DebugModuleImpl.java
Outdated
Show resolved
Hide resolved
fmacleal
approved these changes
Nov 13, 2024
Vovchyk
approved these changes
Nov 15, 2024
fmacleal
force-pushed
the
add-gradle-sonar-scanner
branch
from
4e3f456
to
2aa85a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Sonar Configurations
Motivation and Context
Sonar configurations should be updated in order to take advantage of SonarCloud, taking into consideration the recommended way of doing it for gradle projects, adapting it to the context of Github Actions.
How Has This Been Tested?
By adding a test function plagued by bad practices and with no test coverage (now removed) to confirm that the SonalCloud analysis worked as expected:
Types of changes
Checklist:
N/A