Update testnet validation period duration and activation age #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
force-pushed
the
update_testnet_activation_age
branch
from
8a8662e to
163b160
Compare
julia-zack
force-pushed
the
update_testnet_activation_age
branch
from
163b160 to
d0bcdec
Compare
julia-zack
force-pushed
the
update_testnet_activation_age
branch
2 times, most recently
from
6ca295e to
a85f772
Compare
nathanieliov
reviewed
Jan 2, 2025
rskj-core/src/test/java/co/rsk/peg/federation/constants/FederationConstantsTest.java
Outdated
Show resolved
Hide resolved
nathanieliov
approved these changes
Jan 2, 2025
Base automatically changed from
remove_similar_isSvpOngoing_method
to
feature/powpeg_validation_protocol-phase4
January 6, 2025 21:09
julia-zack
force-pushed
the
update_testnet_activation_age
branch
from
188e766 to
8ca447c
Compare
Use Stream.toList() to ensure lists are unmodifiable Add a new value for pre lovell activation age in testnet
marcos-iov
approved these changes
Jan 8, 2025
marcos-iov
merged commit 27f4e47
into
feature/powpeg_validation_protocol-phase4
6 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current activation age in testnet is set to 120 RSK blocks, and the svp validation period to 80 blocks. This is going to be insufficient to complete the SVP validations.
A safe value to ensure that the SVP has enough time to be validated is 2000 RSK blocks.
This change implies also update the activation age just for testnet.