Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Allow successful mocking of Mutex#synchronize #1575

Merged
merged 4 commits into from
May 8, 2024
Merged

Allow successful mocking of Mutex#synchronize #1575

merged 4 commits into from
May 8, 2024

Commits on May 7, 2024

  1. Add a (bad) failing test that mocks a mutex

    @nevinera
    nevinera committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b83ed26 View commit details
    Browse the repository at this point in the history

  2. Looks for Mutex _in Proxy_ before stashing 

    defined?(Mutex) is always true, back to ruby 2.7 - this check was
intending to avoid reassigning the constant if it already exists, but
accidentally skipped assigning it at all.
    @nevinera
    nevinera committed May 7, 2024
    Configuration menu
    Copy the full SHA
    527f8fe View commit details
    Browse the repository at this point in the history

  3. Explicity use an RSpec::Support::Mutex 

    Rather than relying on the order of namespace-searching. It'll be
clearer to future travellers what's going on here this way.
    @nevinera
    nevinera committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3c6e609 View commit details
    Browse the repository at this point in the history

  4. Just require support/mutex more directly 

    Instead of the existing approach, follow the pattern used by
MessageExpectation - do the Support-require at the top, and jus
reference Support::Mutex directly when instantiating instead of
assigning the constant
    @nevinera
    nevinera committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1558a16 View commit details
    Browse the repository at this point in the history