Prevent invalid encoding for files blowing up

rspec · Feb 5, 2019 · 8bc3b72 · 8bc3b72
1 parent 29f8cd5
commit 8bc3b72
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rspec/support/source.rb b/lib/rspec/support/source.rb
@@ -9,7 +9,11 @@ class Source
       attr_reader :source, :path
 
       def self.from_file(path)
-        source = File.read(path)
+        # We must use `binread` here, there is no spec for this behaviour
+        # as its proven troublesome to replicate within our spec suite, but
+        # to manually verify run:
+        # `bundle exec rspec spec/support/source_spec.broken_example`
+        source = File.binread(path)
         new(source, path)
       end
 

diff --git a/spec/support/source_spec.broken_example b/spec/support/source_spec.broken_example
@@ -0,0 +1,8 @@
+Encoding.default_internal = Encoding::BINARY
+
+describe UndeclaredModule do
+  # the missing constant can be anything
+  it 'crashes and does not even parse this' do
+    'привет'
+  end
+end