Add game mode info to CommanderEntry #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t inner log_state I think this was an oversight during implementing rster2002#95. Currently, there is no possibility for 3rd party code to actually access the current GameCommanderEntry (which makes it impossible to e.g., access the current commanders' name)
Since this information is static during a session, it should be fine to keep it in GameCommanderEntry and not in the LogState?
|
After thinking about it a bit more, I think it makes more sense to move the game_mode field to the LogState struct.. Because the next step would be to also include the current ship info which can change during a session. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also parse the groups' name as part of the GameMode enum. This merge request depends on #96