Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in safeLabel for formula label with empty data #502

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mz8i
Copy link

@mz8i mz8i commented Mar 21, 2018

When adding an empty simple features dataframe to a map and specifying a formula-based label, methods like addPolygons error, because safeLabel fails on empty inputs with

Error in sum(sapply(label, function(x) { : 
  invalid 'type' (list) of argument

(tries to sum an empty list)

Example of failing safeLabel call

safeLabel(~X, data.frame(X=1:10) %>% head(0))

@schloerke schloerke self-assigned this Apr 13, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Maciej Ziarkowski
❌ mz8i


Maciej Ziarkowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jcheng5 jcheng5 added this to the v2.1 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants