add a CSS fix for leaflet to avoid wider CSS to apply #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS conflict happened in Quarto context where a rule on
.legend
was applying to Leaflet own legend boxContext of the issue at
fig-
s quarto-dev/quarto-cli#7843When adding figure caption for a leaflet in Quarto, this will add some CSS bootstrap rules to the document. One being:
This rules has effect on text inside the leaflet object !
I believe there should be a fix in leaflet CSS so that a default alignment is made on the legend box.
This PR does that.
If this is ok fix with you, question: Should visual test be added ?
If you think this shouldn't be done in leaflet R package, this is also ok. We'll probably add a rule in Quarto to not apply the Figure CSS rules on content under
div.html-widget
objectsI just figured this could happen in other context without this CSS patch.