Update stylesheet for code blocks with line-numbers #1596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update stylesheet for code blocks with line-numbers.
Examples are at the bottom.
Changes
Background of
<div class="sourceCode">
is changed to transpreant.In some syntax highlighting, background color of
<div class="sourceCode">
are specified (e.g., tango)This cause ugly appearance especially in
theme: darkly
As long as line numbers are not used, background color of the
div
tags are not visible.Thus, I considered it is okay to letting them
transparent
.Background of
pre
for chunk output are changed to whitePreviously, specifying
class.output="numberLines"
caused output code block to have gray background where white is expected.This is fixed by exact matching of class attributes.
Thus, white background are only applied when
The latter is approached by the exact matching of classes.
Exact matching is required for the backward compatibility.
Otherwise, Bootstrap would not work to fill background colors for example by
class.output = "numberLines bg-warning"
.Note
If the output
pre
tag has thelineAnchors
class, but not thenumberLines
, it is filled with gray.Because line numbering is not working.
Examples
Before
After
Source