Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy対応 #198

Merged
merged 31 commits into from
Jan 9, 2025
Merged

Jazzy対応 #198

merged 31 commits into from
Jan 9, 2025

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Dec 26, 2024

What does this implement/fix?

Jazzy対応します

Does this close any currently open issues?

しません

How has this been tested?

Gazebo、実機両方で全てのサンプルが動作することを確認します。

Any other comments?

下記PRマージ後にテストが正常に動作します。
rt-net/crane_x7_description#10

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Dec 26, 2024
@Kuwamai Kuwamai self-assigned this Dec 26, 2024
@Kuwamai Kuwamai requested a review from YusukeKato December 26, 2024 09:27
@YusukeKato
Copy link
Contributor

Ubuntu 24.04 LTS + ROS 2 Jazzy環境において、Gazebo上ですべてのサンプルが動作することを確認しました(カメラサンプルは除く)。

Gazebo起動時に下記のエラーが出るので共有します。

$ ros2 launch crane_x7_gazebo crane_x7_with_table.launch.py
...
[gz sim -r-1] [Err] [Physics.cc:1773] Attempting to create a mimic constraint for joint [crane_x7_gripper_finger_b_joint] but the chosen physics engine does not support mimic constraints, so no constraint will be created.
...

@Kuwamai Kuwamai marked this pull request as ready for review January 7, 2025 03:08
Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一か所だけ細かい指摘ですがコメントしましたので確認をお願いします。
その他は問題ないと思います。

.github/workflows/industrial_ci.yml Outdated Show resolved Hide resolved
Co-authored-by: YusukeKato <YusukeKato@users.noreply.github.com>
@Kuwamai
Copy link
Contributor Author

Kuwamai commented Jan 8, 2025

Ubuntu 24.04 LTS + ROS 2 Jazzy環境において、Gazebo上ですべてのサンプルが動作することを確認しました(カメラサンプルは除く)。

Gazebo起動時に下記のエラーが出るので共有します。

$ ros2 launch crane_x7_gazebo crane_x7_with_table.launch.py
...
[gz sim -r-1] [Err] [Physics.cc:1773] Attempting to create a mimic constraint for joint [crane_x7_gripper_finger_b_joint] but the chosen physics engine does not support mimic constraints, so no constraint will be created.
...

こちらのエラーについては動作に問題ないようです。
記録として後ほどissueにまとめようと思います。
rt-net/sciurus17_ros#158 (comment)

Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。
LGTMです!

Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加修正を確認しました。
LGTMです!

@YusukeKato YusukeKato merged commit d82509b into ros2 Jan 9, 2025
2 checks passed
@YusukeKato YusukeKato deleted the support_jazzy branch January 9, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants