Tomaster #188
Merged
Tomaster #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create a function to check if a short-term storage cluster exists : check_cluster_name() * Control cluster existence for short-term storage before action (create, edit, remove) * Create a function to generate a cluster name : generate_cluster_name()
…ea() (#154) * Add function to control the existence of a link, a cluster or an area in a binding constraint coefficient * Comment tests in failure for createPSP() and create DSR() * Add comments, factorize code, use cluster_name already lowerized in .removeCluster()
Co-authored-by: kemihak <kamel.kemiha@rte-france.com>
…#155) * Remove expected files for thermal mode in the prepro subdirectory * Add unit tests to check that expected files are deleted for removeCluster(), removeClusterRES() and removeClusterST() * Enrich tests to check that directory area is there for the N-1 first clusters
fix news md resolve conflicts in test Merge branch 'master' of https://github.com/rte-antares-rpackage/antaresEditObject into develop # Conflicts: # tests/testthat/test-createCluster.R
* Specify encoding argument in .getJobs()
#161) * editArea should not remove economic option value if not provided in nodalOptimization argument
… nodalOptimization (#163) * API mode split list to write in nodalOptimization by target file * Factorize economic variables definition and factorize function createArea by chunks * Use .split_nodalOptimization_by_target, factorize code and rename variables * Add readIniFile in importFrom * Ensure that NULL is returned if there is no intersection * Edit properties for input/thermal/areas.ini in API mode * Add unit tests for .split_nodalOptimization_by_target() * Define variable params only if lst_params is not null for optimization * Rename argument and add documentation
* Loop on each property to edit to generate the commands to execute in API mode * Rename variables after code review
* fix test createCluster.R * test-createClusterST study 8.6 template removed * test-createStudy template study 8.6 removed * test-editCluster study860 removed * comments removed after code review * template 8.6 removed for test editCluster and editClusteST * test editClusterST corrected * template 8.6 removed from test editLink * template 8.6 removed from writeHydroValues * writeInput ongoing * writeInputTs with test commented * template study8.6 removed from tests completed * Removal of the setup_study_860 function from the helper_init.R file * update tests about bindingconstraints and read properties with readIni() instead of readbingConstraints() to prevent side effects --------- Co-authored-by: vargastat <tatiana.vargas@rte-france.com>
# antaresEditObject 0.7.0 (development) > Second-member coupling constraint scenarios NEW FEATURES (Antares v8.7, cf. Antares v8.7 changelog) : * `createBindingConstraint()` / `createBindingConstraintBulk()` - New parameters `group` - Parameter `values` is now list of `data.frame` * `editBindingConstraint()` - New parameters `group` - Parameter `values` is now list of `data.frame` * `removeBindingConstraint()` can now delete coupling constraints from the `group` parameter. * `scenarioBuilder()` has 3 new parameters dedicated to use with binding constraints. * `updateGeneralSettings()` adds coupling constraints to the `scenariobuilder.dat` file. ### Breaking changes : * `createBindingConstraint()` is available with **offset** parameter in API mode
* add private function group_values_meta_check() to check dim with meta data in opts + tests * update version and news.md * update createbinding + bulk + doc + test * update editBindingConstraint with new private function to check group dim * replace function to check dim by group_values_meta_check * update DESCRIPTION file remotes
* Add parameter solver.log in updateOptimizationSettings() for version >= 8.8
* Remove R/antaresRead-reexports.R and make the operations to have a clean check
…ests (#175) Co-authored-by: kemihak <kamel.kemiha@rte-france.com>
…nation (#174) * Add folder_destination and delete_zipfile arguments to importZipStudyWeb * Fix CI/CD alert : provide package anchors for all Rd \link{} targets not in the package itself and the base packages. * Update .Rd file after package check
* create + edit storage updated to manage v880 parameter + cleaning + tests * createClusterST() updated with temporary solution for api part causing error if cluster already exist + tests * create/edit cluster ST suppress warning in api part * update docs + newmd
* fix side effects from antaresRead function (readClusterDesc, ...) * update newsmd
* fix creation bc in text mode * createBindingConstraint() cleaning code + add tests to test real values * editBindingConstraint() fixed with values + specfic tests on values * newsmd updated * cleaning createBindingConstraint() from review
* fix createBindingConstraintBulk() with NULL or mixed values + tests * Adjust comments
* Add package lifecycle in Imports section * Update NEWS.md * Replace custom.ts.numbers by custom.scenario in updateGeneralSettings() * Changes after code review
* Control matrix dimension not at the first index * Call new function switch_to_list_name_operator_870() whenever it is possible * Add test for a case with both operator * Define function outside and treat NULL case
* Ensure that the variable name is not a column name for a data.table * Add file for testing utils.R * Add argument name in call of check_cluster_name()
* Add thematic.trimming argument in updateGeneralSettings(), update link in documentation and add unit test * Update documentation * Replace utils::modifyList by modifyList
…nd filter_year_by_year (#183) * editLink() : avoid NULL values for arguments filter_synthesis and filter_year_by_year to write an empty string and replace the previous values * Replace data.table::as.data.table by as.data.table and data.table::fwrite by fwrite
* Clean the list by dropNulls before trying to write data, build the function updateOutputSettings() on the same model as updateInputSettings() with dicoOutputSettings() * Use .format_ini_rhs for factorization * Add unit tests
* createClusterST() doc updated to describe list parameters * update to dev version + build site dev version * fix doc "inflows" parameter definition * fix warning to display image
* update doc note section + examples
Merge branch 'master' of https://github.com/rte-antares-rpackage/antaresEditObject into tomaster # Conflicts: # DESCRIPTION # NAMESPACE # NEWS.md # R/createBindingConstraint.R # R/createClusterST.R # R/editBindingConstraint.R # R/editClusterST.R # R/removeArea.R # R/removeCluster.R # R/removeLink.R # R/utils.R # man/createBindingConstraint.Rd # man/editBindingConstraint.Rd # man/removeBindingConstraint.Rd # tests/testthat/test-createArea.R # tests/testthat/test-createBindingConstraint.R # tests/testthat/test-createCluster.R # tests/testthat/test-createClusterST.R # tests/testthat/test-createLink.R # tests/testthat/test-editBindingConstraint.R # tests/testthat/test-editClusterST.R # tests/testthat/test-editLink.R # tests/testthat/test-writeInputTS.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion of the “develop” branch and repatriation of commits to the master branch :