fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl · Apr 17, 2024 · 39bb304 · 39bb304
1 parent 0810ec5
commit 39bb304
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/...workspace/server/saved_objects/saved_objects_wrapper_for_check_workspace_conflict.test.ts b/...workspace/server/saved_objects/saved_objects_wrapper_for_check_workspace_conflict.test.ts
@@ -326,16 +326,21 @@ describe('WorkspaceConflictSavedObjectsClientWrapper', () => {
     });
     it(`Should return error when trying to create disallowed types within a workspace`, async () => {
       mockedClient.bulkCreate.mockResolvedValueOnce({ saved_objects: [] });
-      const result = await wrapperClient.bulkCreate([
-        getSavedObject({
-          type: 'config',
-          id: 'foo',
-        }),
-        getSavedObject({
-          type: DATA_SOURCE_SAVED_OBJECT_TYPE,
-          id: 'foo',
-        }),
-      ]);
+      const result = await wrapperClient.bulkCreate(
+        [
+          getSavedObject({
+            type: 'config',
+            id: 'foo',
+          }),
+          getSavedObject({
+            type: DATA_SOURCE_SAVED_OBJECT_TYPE,
+            id: 'foo',
+          }),
+        ],
+        {
+          workspaces: ['foo'],
+        }
+      );
 
       expect(mockedClient.bulkCreate).toBeCalledWith([], {
         workspaces: ['foo'],

diff --git a/...gins/workspace/server/saved_objects/saved_objects_wrapper_for_check_workspace_conflict.ts b/...gins/workspace/server/saved_objects/saved_objects_wrapper_for_check_workspace_conflict.ts
@@ -219,7 +219,7 @@ export class WorkspaceConflictSavedObjectsClientWrapper {
       /**
        * Get all the objects that do not conflict on workspaces
        */
-      const objectsNoWorkspaceConflictError = objects.filter(
+      const objectsNoWorkspaceConflictError = allowedSavedObjects.filter(
         (item) =>
           !objectsConflictWithWorkspace.find(
             (errorItems) =>