Support to display workspace feature configured with wildcard #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #186 +/- ##
=============================================
+ Coverage 66.09% 66.12% +0.02%
=============================================
Files 3420 3420
Lines 65747 65753 +6
Branches 10590 10590
=============================================
+ Hits 43456 43478 +22
+ Misses 19650 19634 -16
Partials 2641 2641
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
reviewed
Sep 22, 2023
| // expanded to array of individual feature id, if the feature hasn't changed, we will | ||
| // set the feature config back to the original value so that category wildcard won't | ||
| // expanded to feature ids | ||
| formData.features = defaultValues?.features ?? []; |
There was a problem hiding this comment.
Is that means the wildcard match will be removed after add some new feature ids?
There was a problem hiding this comment.
Yes, that makes sense to me as that's what the user selected
There was a problem hiding this comment.
OK. Just wonder if we can support wildcard for the feature category level. Which means if user select a feature category, we will store wildcard feature rule. If they remove some one, we will change to feature ids.
There was a problem hiding this comment.
Sounds good to me, we could have an improvement ticket for this.
SuZhou-Joe
approved these changes
Sep 25, 2023
1. In workspace update page, support to display workspace feature configured with wildcard. 2. Fixed an issue which generateWorkspacePermissionError return void 3. Fixed an issue which workspace route validation failed due to missing permission mode in schema Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
feature/support-wildcard-on-ui
branch
from
b0731a4 to
fe976fa
Compare
raintygao
approved these changes
Sep 25, 2023
wanglam
approved these changes
Sep 25, 2023
opensearch-workspace-development bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Support to display workspace feature configured with wildcard 1. In workspace update page, support to display workspace feature configured with wildcard. 2. Fixed an issue which generateWorkspacePermissionError return void 3. Fixed an issue which workspace route validation failed due to missing permission mode in schema Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * update dependence array Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 25b9e5c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr