feat: update create workspace page UI and implement unit tests #226

yuye-aws · 2023-10-13T00:51:08Z

Description

Issues Resolved

Update create workspace page UI
Implement unit tests

Screenshot

Testing the changes

Check List

codecov-commenter · 2023-10-13T01:09:04Z

Codecov Report

Merging #226 (8b22c35) into workspace (7a72a73) will decrease coverage by 5.81%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #226      +/-   ##
=============================================
- Coverage      66.19%   60.39%   -5.81%     
=============================================
  Files           3431     2162    -1269     
  Lines          65952    42121   -23831     
  Branches       10616     7728    -2888     
=============================================
- Hits           43659    25437   -18222     
+ Misses         19645    14993    -4652     
+ Partials        2648     1691     -957

Flag	Coverage Δ
Linux_1	`?`
Linux_2	`55.41% <ø> (ø)`
Linux_3	`42.77% <ø> (ø)`
Linux_4	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1569 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/plugins/workspace/public/components/workspace_creator/workspace_creator.test.tsx

src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx

SuZhou-Joe · 2023-10-13T08:33:12Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator.test.tsx

+import React from 'react';
+import { WorkspaceCreator } from './workspace_creator';
+import { PublicAppInfo } from 'opensearch-dashboards/public';
+import { fireEvent, render, waitFor } from '@testing-library/react';
+import * as opensearchReactExports from '../../../../opensearch_dashboards_react/public';
+import { BehaviorSubject } from 'rxjs';
+import { WorkspaceFormSubmitData } from './workspace_form';


It would be better that we import absolute module in the beginning and then relative module. I do not know why OSD lint do not automatically format that but we'd better follow the standard pattern.

SuZhou-Joe · 2023-10-13T08:35:06Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator.test.tsx

+jest.mock('../../../../opensearch_dashboards_react/public', () => ({
+  ...jest.requireActual('../../../../opensearch_dashboards_react/public'),
+  __esModule: true,
+}));


If we return the actual implementation of the target module, why do we doMock on the path?

SuZhou-Joe · 2023-10-13T08:38:14Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator.test.tsx

+  services: {
+    application: {
+      navigateToApp,
+      getUrlForApp: jest.fn(),
+      applications$: new BehaviorSubject<Map<string, PublicAppInfo>>(PublicAPPInfoMap as any),
+    },
+    http: {
+      basePath: {
+        remove: jest.fn(),
+        prepend: jest.fn(),
+      },
+    },
+    notifications: {
+      toasts: {
+        addDanger: notificationToastsAddDanger,
+        addSuccess: notificationToastsAddSuccess,
+      },
+    },
+    workspaceClient: {
+      create: workspaceClientCreate,
+    },
+  },


can we use

...coreServiceMock.create() ...{ application: {...}, notifications: {...}, workspaceClient: {...} }

In this case, if coreStart adds any new fields, we do not need to modify the mock here.

SuZhou-Joe · 2023-10-13T08:42:57Z

src/plugins/workspace/public/components/workspace_creator/workspace_icon_selector.tsx

-          grow={false}
-        >
-          <EuiIcon size="l" type={item} color={value === item ? color : undefined} />
+  const icons = ['Glasses', 'Search', 'Bell', 'Package'];


I'd recommend moving this statement out of the function body if it is a static property.

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx

SuZhou-Joe · 2023-10-13T09:02:15Z

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx

-        />
+          aria-label="Delete permission setting"
+        >
+          Remove


i18n wrapper maybe?

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx

SuZhou-Joe · 2023-10-13T09:05:24Z

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx

+        color={'text'}
+        data-test-subj="workspaceForm-permissionSettingPanel-addNew"
+      >
+        Add New


i18n wrapper maybe.

src/plugins/workspace/public/components/workspace_updater/workspace_updater.tsx

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

…space_updater.tsx Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

…space_permission_setting_panel.tsx Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

github-actions bot added the all-star-contributor label Oct 13, 2023

yuye-aws requested a review from wanglam October 13, 2023 01:02

yuye-aws requested review from ruanyl and gaobinlong October 13, 2023 04:45

wanglam reviewed Oct 13, 2023

View reviewed changes

SuZhou-Joe reviewed Oct 13, 2023

View reviewed changes

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Oct 13, 2023

View reviewed changes

...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Oct 13, 2023

View reviewed changes

src/plugins/workspace/public/components/workspace_updater/workspace_updater.tsx Outdated Show resolved Hide resolved

yuye-aws added 15 commits October 16, 2023 19:25

ui update: workspace create page

0cd5dd7

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

implement cancel button and wrap string with i18n

536cd95

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

eslint fix

58e6e66

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

breadcrumb bug fix

a2bece0

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

workspace create unit tests

0ddba6a

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

bug fix

019183e

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update bread crumbs for workspace create page

0e6dbb1

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

udpate test case

e8a6866

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

optimize create page ui

b455fab

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update test file

819df61

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

change library category definition

61c0a27

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove key definition

6dfa790

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

change default permission type to Read

8c81cae

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

refactor bottom bar and cancel modal into components

f268305

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

declare consts outside functional components

e509ee2

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

yuye-aws and others added 19 commits October 16, 2023 19:27

remove key definition

1e2abca

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

refactor bottom bar and cancel model

91e14fc

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

Update src/plugins/workspace/public/components/workspace_updater/work…

384f421

…space_updater.tsx Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

Update src/plugins/workspace/public/components/workspace_creator/work…

9ed01e9

…space_permission_setting_panel.tsx Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

Update src/plugins/workspace/public/components/workspace_creator/work…

c771dd4

…space_permission_setting_panel.tsx Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

wrap string with i18n

7090e96

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

reimplement tab selection to enum

d457700

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

fix data-test-subj duplicate bug

59aa149

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update tests and id

c471278

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update UI

0067a4c

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

track the number of errors

deeddad

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

add test cases

3b1fe21

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

resolve conflicts

086ee4d

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

hide permission section when workspace permission is not enabled

61f40f6

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

sort permissions decreasingly

ca6c263

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update test file

9b04975

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

feat: remove some error and optimize mock

2fb0001

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

59d37f1

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

update test file

ea35faf

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

SuZhou-Joe approved these changes Oct 17, 2023

View reviewed changes

yuye-aws added 3 commits October 17, 2023 14:20

refactor with EuiTab

2a6dba3

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove sort logic

e96ddb0

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove unused import

8b22c35

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

yuye-aws requested a review from wanglam October 17, 2023 07:33

wanglam approved these changes Oct 17, 2023

View reviewed changes

yuye-aws merged commit f00cb3c into ruanyl:workspace Oct 17, 2023
20 of 21 checks passed

yuye-aws deleted the update-create branch January 3, 2024 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update create workspace page UI and implement unit tests #226

feat: update create workspace page UI and implement unit tests #226

yuye-aws commented Oct 13, 2023 •

edited

Loading

codecov-commenter commented Oct 13, 2023 •

edited

Loading

SuZhou-Joe Oct 13, 2023

SuZhou-Joe Oct 13, 2023

SuZhou-Joe Oct 13, 2023 •

edited

Loading

SuZhou-Joe Oct 13, 2023

SuZhou-Joe Oct 13, 2023

SuZhou-Joe Oct 13, 2023

feat: update create workspace page UI and implement unit tests #226

feat: update create workspace page UI and implement unit tests #226

Conversation

yuye-aws commented Oct 13, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter commented Oct 13, 2023 • edited Loading

Codecov Report

SuZhou-Joe Oct 13, 2023

Choose a reason for hiding this comment

SuZhou-Joe Oct 13, 2023

Choose a reason for hiding this comment

SuZhou-Joe Oct 13, 2023 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe Oct 13, 2023

Choose a reason for hiding this comment

SuZhou-Joe Oct 13, 2023

Choose a reason for hiding this comment

SuZhou-Joe Oct 13, 2023

Choose a reason for hiding this comment

yuye-aws commented Oct 13, 2023 •

edited

Loading

codecov-commenter commented Oct 13, 2023 •

edited

Loading

SuZhou-Joe Oct 13, 2023 •

edited

Loading