-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport workspace] Left navigation menu adjustment (#192) #233
[Backport workspace] Left navigation menu adjustment (#192) #233
Conversation
* add util function to filter workspace feature by wildcard Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update tests and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * small adjustment to left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve git conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename nav link service function Signed-off-by: yuye-aws <yuyezhu@amazon.com> * unit test for workspace plugin.ts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> * optimize code Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace #233 +/- ##
==============================================
- Coverage 66.19% 55.34% -10.86%
==============================================
Files 3431 3149 -282
Lines 65952 62254 -3698
Branches 10616 10078 -538
==============================================
- Hits 43659 34456 -9203
- Misses 19645 25677 +6032
+ Partials 2648 2121 -527
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 696 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-pr-integr workspace-pr-integr
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-pr-integr
# Create a new branch
git switch --create backport/backport-233-to-workspace-pr-integr
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4dfa3094f8aed8d0c606b2c32729c31db9b79ee
# Push it to GitHub
git push --set-upstream origin backport/backport-233-to-workspace-pr-integr
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-pr-integr Then, create a pull request where the |
Description
This is the backport PR from #192. Changes include:
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr