forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update workspace list page #238
Merged
raintygao
merged 6 commits into
ruanyl:workspace
from
raintygao:feat-workspace-list-update
Oct 27, 2023
Merged
update workspace list page #238
raintygao
merged 6 commits into
ruanyl:workspace
from
raintygao:feat-workspace-list-update
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #238 +/- ##
==============================================
- Coverage 66.21% 55.34% -10.88%
==============================================
Files 3438 3149 -289
Lines 66270 62274 -3996
Branches 10694 10081 -613
==============================================
- Hits 43880 34463 -9417
- Misses 19707 25688 +5981
+ Partials 2683 2123 -560
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 701 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
reviewed
Oct 24, 2023
src/plugins/workspace/public/components/workspace_list/index.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_list/index.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_list/index.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_list/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
force-pushed
the
feat-workspace-list-update
branch
from
October 26, 2023 06:24
f4c3aac
to
d3a7982
Compare
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
wanglam
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr