Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workspace list page #238

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

raintygao
Copy link
Collaborator

Description

  1. support search name and id
  2. add multi select checkbox
  3. support jump to edit workspace page
  4. test suites will be included in integration PR

Issues Resolved

Screenshot

image

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@raintygao raintygao marked this pull request as ready for review October 23, 2023 06:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #238 (602c3ca) into workspace (7e2ace0) will decrease coverage by 10.88%.
Report is 1 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           workspace     #238       +/-   ##
==============================================
- Coverage      66.21%   55.34%   -10.88%     
==============================================
  Files           3438     3149      -289     
  Lines          66270    62274     -3996     
  Branches       10694    10081      -613     
==============================================
- Hits           43880    34463     -9417     
- Misses         19707    25688     +5981     
+ Partials        2683     2123      -560     
Flag Coverage Δ
Linux_1 30.88% <ø> (+0.04%) ⬆️
Linux_2 ?
Linux_3 42.77% <ø> (+<0.01%) ⬆️
Linux_4 34.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ublic/components/workspace_menu/workspace_menu.tsx 2.85% <ø> (+0.15%) ⬆️

... and 701 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@raintygao raintygao force-pushed the feat-workspace-list-update branch from f4c3aac to d3a7982 Compare October 26, 2023 06:24
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@raintygao raintygao merged commit d1fe469 into ruanyl:workspace Oct 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants