Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace]Feature: create management / public workspaces when calling list api … #240

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Oct 23, 2023

…(#236)

  • feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: fix bootstrap

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • fix: integration test

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • fix: flaky test

Signed-off-by: SuZhou-Joe suzhou@amazon.com


Signed-off-by: SuZhou-Joe suzhou@amazon.com
(cherry picked from commit 8ff9e88)

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…pensearch-project#236)

* feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: integration test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: flaky test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 8ff9e88)
@SuZhou-Joe SuZhou-Joe changed the title Feature: create management / public workspaces when calling list api … [Backport workspace]Feature: create management / public workspaces when calling list api … Oct 23, 2023
@SuZhou-Joe SuZhou-Joe marked this pull request as draft October 23, 2023 09:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #240 (534269c) into workspace (1ac7ec4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           workspace     #240   +/-   ##
==========================================
  Coverage      66.21%   66.21%           
==========================================
  Files           3438     3438           
  Lines          66262    66262           
  Branches       10691    10691           
==========================================
  Hits           43878    43878           
  Misses         19703    19703           
  Partials        2681     2681           
Flag Coverage Δ
Linux_1 30.84% <ø> (ø)
Linux_2 55.41% <ø> (ø)
Linux_3 42.77% <ø> (ø)
Linux_4 34.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants