Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dynamic mapping when migrate #262

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Feb 29, 2024

Description

try to make workspaces field dynamic because workspace is a experimental feature.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.45%. Comparing base (587f0d4) to head (f9b3523).
Report is 1 commits behind head on workspace.

Files Patch % Lines
...d_objects/migrations/core/build_active_mappings.ts 0.00% 3 Missing ⚠️
...saved_objects/migrations/core/migration_context.ts 0.00% 2 Missing ⚠️
...earch_dashboards/opensearch_dashboards_migrator.ts 0.00% 2 Missing ⚠️
...core/server/saved_objects/saved_objects_service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           workspace     #262       +/-   ##
==============================================
- Coverage      66.71%   55.45%   -11.26%     
==============================================
  Files           3336     3049      -287     
  Lines          64764    60812     -3952     
  Branches       10439     9836      -603     
==============================================
- Hits           43206    33726     -9480     
- Misses         18977    25027     +6050     
+ Partials        2581     2059      -522     
Flag Coverage Δ
Linux_1 31.41% <0.00%> (+0.34%) ⬆️
Linux_2 ?
Linux_3 41.74% <0.00%> (+0.03%) ⬆️
Linux_4 34.88% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@@ -34,6 +34,7 @@

import crypto from 'crypto';
import { cloneDeep, mapValues } from 'lodash';
import { Config } from 'packages/osd-config/target';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import seems not correct, might need double check

@SuZhou-Joe SuZhou-Joe closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants