remove management workspace #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
reviewed
Mar 5, 2024
src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace #278 +/- ##
=============================================
- Coverage 66.76% 66.76% -0.01%
=============================================
Files 3337 3337
Lines 64809 64803 -6
Branches 10456 10452 -4
=============================================
- Hits 43270 43265 -5
+ Misses 18952 18951 -1
Partials 2587 2587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Mar 5, 2024
SuZhou-Joe
reviewed
Mar 6, 2024
SuZhou-Joe
reviewed
Mar 6, 2024
SuZhou-Joe
approved these changes
Mar 6, 2024
ruanyl
pushed a commit
that referenced
this pull request
Mar 7, 2024
* remove management workspace (#278) * remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts * update typescript version to 4.6.4 * delete useless code and add a lost yarn.lock * delete yarn.lock
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
* remove management workspace (#278) * remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts * update typescript version to 4.6.4 * delete useless code and add a lost yarn.lock * delete yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove management workspace
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration