forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard admin(groups/users) implementation and integrating with dynamic application config #303
Merged
SuZhou-Joe
merged 27 commits into
ruanyl:workspace-pr-integr
from
yubonluo:pr-integr-dashboard-admin
Apr 12, 2024
Merged
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
72fc938
dashboard admin(groups/users) implementation and add unit/integration…
yubonluo 29236e3
Add test cases of user Id matching dashboard admin
yubonluo 22323c1
delete useless code
yubonluo f9666a0
change isDashboard function name to isRequestByDashboardAdmin
yubonluo 123c87e
Merge branch 'workspace-pr-integr' of github.com:ruanyl/OpenSearch-Da…
yubonluo 166451a
dashboard admin config integrating with dynamic application config
yubonluo 363aeaa
Optimize the code
yubonluo c8bb0b5
fix test error
yubonluo 74d9a26
delete useless code
yubonluo a07dde0
optimize code
yubonluo 518cd75
optimize code and add unit test
yubonluo dc77999
optimize code according to comments
yubonluo 71c20d9
change dashboardAdmin yml config to openseachDashboard
yubonluo c61dac9
add missed code
yubonluo 0bf41b3
solve conflict
yubonluo f0c1b5d
optimize code
yubonluo 2018bdf
Merge branch 'workspace-pr-integr' into pr-integr-dashboard-admin
yubonluo 979851a
solve conflict
yubonluo 3a70922
solve conflict
yubonluo a69cc58
delete useless code
yubonluo 7d83f48
delete useless code
yubonluo f50093f
optimize code
yubonluo e9fd21a
delete useless code
yubonluo 909af1c
add utils unit tests
yubonluo b342950
Merge branch 'workspace-pr-integr' of github.com:ruanyl/OpenSearch-Da…
yubonluo 27d95fe
optimize code
yubonluo acfb166
Fix the wrong reference
yubonluo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming
workspace.dashboardAdmin
may confuse me, it sounds like the admin for dashboard type only. I come few names likeworkspace.dashboardsAdmin
,workspace.admin
orworkpsace.superAdmin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspace.admin may be confusing as
admin of workspace
stands for the the users who have write permission on specific workspaces, vote for superAdmin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no configuration named
workspace.admin
, wouldworkspace.superAdmin
also be confused?