fix: two "Overview"s under library section #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
wanglam
reviewed
Aug 21, 2023
| @@ -135,11 +136,11 @@ export class SavedObjectsManagementPlugin | |||
| id: 'objects_overview', | |||
There was a problem hiding this comment.
Do we need to update the id here?
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
wanglam
approved these changes
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## workspace #94 +/- ##
=============================================
- Coverage 65.81% 60.74% -5.07%
=============================================
Files 3334 2896 -438
Lines 64404 56484 -7920
Branches 10248 9035 -1213
=============================================
- Hits 42385 34312 -8073
- Misses 19451 20158 +707
+ Partials 2568 2014 -554
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 686 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanyl
approved these changes
Aug 22, 2023
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* rename the second overview in library category to all library objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change id from objects_overview to objects_all Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* rename the second overview in library category to all library objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change id from objects_overview to objects_all Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* rename the second overview in library category to all library objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change id from objects_overview to objects_all Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the second Overview in library category to All library objects and changes title from Saved Objects to Library objects in Analytics
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr