Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Ambiguity in MVVM (Full) CommandBinding #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Reduce Ambiguity in MVVM (Full) CommandBinding #12

wants to merge 5 commits into from

Commits on Jan 14, 2024

  1. Update CommandBinding.cls 

    CommandBinding uses internally stored ViewModel for the Execute action.

Doesn't make sense to evaluate CanExecute in an arbitrary context - it should also use the stored ViewModel.

Also requires change to ICommandBinding
    @jhiston
    jhiston committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    6403d57 View commit details
    Browse the repository at this point in the history

  2. Update ICommandBinding.cls 

    See other proposed change as well.

Breaking? change to interface, but removes confusion caused by a CommandBinding potentially evaluating CanExecute in an arbitrary context (Context as object) but always executing the Command with respect to an internally stored ViewModel
    @jhiston
    jhiston committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    6944dc8 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from jhiston/patch-2 

    Update ICommandBinding.cls
    @jhiston
    jhiston committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    8a59a6f View commit details
    Browse the repository at this point in the history

  4. Update ICommandBinding.cls

    @jhiston
    jhiston committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    9a7d1cc View commit details
    Browse the repository at this point in the history

  5. Update CommandBinding.cls

    @jhiston
    jhiston committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    e6b292b View commit details
    Browse the repository at this point in the history