Fix serialization of GraphQL responses (#51)

* Fix serialization of GraphQL responses * Trigger CI
rubrikinc · Mar 14, 2024 · cc7020e · cc7020e
1 parent 55225f3
commit cc7020e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 34 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 Fixes:
 
+- Fixed an issue in which certain GraphQL calls responded with
+  `Unable to cast object of type 'Newtonsoft.Json.Linq.JValue'
+  to type 'Newtonsoft.Json.Linq.JObject'.`
+
 New Features:
 
 Breaking Changes:

diff --git a/RubrikSecurityCloud/RubrikSecurityCloud.Client/GraphQLClient.cs b/RubrikSecurityCloud/RubrikSecurityCloud.Client/GraphQLClient.cs
@@ -310,43 +310,9 @@ private async Task<T> InvokeGraphQLQuery<T>(
                 throw new System.Net.Http.HttpRequestException(msg);
             }
 
-            JObject reply = response.Data as JObject;
-            RenameInterfaceFields(reply);
             return response.Data;
         }
 
-        private void RenameInterfaceFields(JObject replyObject)
-        {
-            const string interfaceFieldId = "_INTERFACE_FIELD_";
-            foreach (JProperty field in replyObject.Properties().ToList())
-            {
-                if (field.Name.Contains(interfaceFieldId))
-                {
-                    string fieldname = field.Name
-                        .Split(
-                            new[] { interfaceFieldId },
-                            StringSplitOptions.RemoveEmptyEntries
-                        )
-                        .Last();
-                    JProperty newField =
-                        new JProperty(fieldname, field.Value);
-                    field.Replace(newField);
-                }
-
-                if (field.Value.Type == JTokenType.Object)
-                {
-                    RenameInterfaceFields(field.Value as JObject);
-                }
-                else if (field.Value.Type == JTokenType.Array)
-                {
-                    foreach (JObject subfield in field.Value)
-                    {
-                        RenameInterfaceFields(subfield);
-                    }
-                }
-            }
-        }
-
         private string GraphQLRequestToString(GraphQLRequest request)
         {
             if (request == null)