Remove deprecated except and proc in values validator #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericproulx
changed the title
Generated by 🚫 Danger |
Fix rubocop
dblock
requested changes
Sep 27, 2024
UPGRADING.md
Outdated
| #### Remove deprecated methods | ||
|
|
||
| Deprecated `file` method has been removed. Use `send_file` or `stream`. | ||
| #### Remove deprecated methods and options |
There was a problem hiding this comment.
Suggested change
| #### Remove deprecated methods and options | |
| #### Remove Deprecated Methods and Options |
UPGRADING.md
Outdated
|
|
||
| - Deprecated `file` method has been removed. Use `send_file` or `stream`. | ||
| See [#2500](https://github.com/ruby-grape/grape/pull/2500) |
There was a problem hiding this comment.
Suggested change
| See [#2500](https://github.com/ruby-grape/grape/pull/2500) | |
| See [#2500](https://github.com/ruby-grape/grape/pull/2500) for more information. |
UPGRADING.md
Outdated
| See [#2500](https://github.com/ruby-grape/grape/pull/2500) | ||
|
|
||
| - `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`. |
There was a problem hiding this comment.
Suggested change
| - `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`. | |
| - The `except` and `proc` options have been removed from the `values` validator. Use `except_values` validator or assign `proc` directly to `values`. |
UPGRADING.md
Outdated
| See [#2500](https://github.com/ruby-grape/grape/pull/2500) | ||
|
|
||
| - `except` and `proc` options have been removed from the `values` validator. Use `except validator` or assign `proc` directly to `values`. | ||
| See [#2501](https://github.com/ruby-grape/grape/pull/2501) |
There was a problem hiding this comment.
Suggested change
| See [#2501](https://github.com/ruby-grape/grape/pull/2501) | |
| See [#2501](https://github.com/ruby-grape/grape/pull/2501) for more information. |
dblock
reviewed
Sep 27, 2024
dblock
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the option
procandexceptin the values validator. It's been deprecated since version 1.0.0