Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure z to be not nil #100

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Make sure z to be not nil #100

merged 1 commit into from
Sep 14, 2023

Conversation

yui-knk
Copy link
Collaborator

@yui-knk yui-knk commented Sep 14, 2023

Digraph#traverse push argment first. This means while loop stops before stack to be empty because it will be break if argment is popped. Checking the result of @stack.pop in while condition expr, so that we can ensure z to be not nil on semantics level.

`Digraph#traverse` push argment first. This means while loop stops
before stack to be empty because it will be break if argment is popped.
Checking the result of `@stack.pop` in while condition expr, so that
we can ensure `z` to be not nil on semantics level.
@yui-knk
Copy link
Collaborator Author

yui-knk commented Sep 14, 2023

This is a follow up of #99.

@yui-knk yui-knk merged commit 08fa2b5 into ruby:master Sep 14, 2023
11 checks passed
@yui-knk yui-knk deleted the refactor_digraph branch September 14, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant