Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a newline at the end of C_DECLARATION in epilogue #141

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add a newline at the end of C_DECLARATION in epilogue #141

merged 1 commit into from
Oct 19, 2023

Conversation

ydah
Copy link
Collaborator

@ydah ydah commented Oct 19, 2023 •
edited
Loading

@yui-knk
Copy link
Collaborator

yui-knk commented Oct 19, 2023 •
edited
Loading

I think there is 3 approachs for this problem.

  1. Add a new line to template/bison/yacc.c (this PR)
  2. Use \z for end_symbol of epilogue_opt
  3. Add another lexer state for epilogue because epilogue can be simply treated line by line

This is most simple approach, then I will try this first.

@yui-knk yui-knk merged commit 0be2334 into ruby:master Oct 19, 2023
14 checks passed
@ydah ydah deleted the add-newline branch October 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @yui-knk