Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NewParser with Parser #Fin #142

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Replace NewParser with Parser #Fin #142

merged 2 commits into from
Oct 19, 2023

Conversation

junk0612
Copy link
Collaborator

  • Remove old hand-made parser
  • Rename Lrama::NewParser to Lrama::Parser

@junk0612 junk0612 force-pushed the rip-handmade-parser branch 2 times, most recently from 9ee4537 to bc916a3 Compare October 19, 2023 13:08
@yui-knk
Copy link
Collaborator

yui-knk commented Oct 19, 2023 •
edited
Loading

Could you also update this line

lrama/.github/workflows/test.yaml

Line 61 in 0be2334

git diff --color --no-ext-diff --ignore-submodules --exit-code lib/lrama/new_parser.rb
?

The last force push resolves this point.

@yui-knk
Copy link
Collaborator

yui-knk commented Oct 19, 2023

💯

@yui-knk yui-knk merged commit 7ef6f70 into ruby:master Oct 19, 2023
14 checks passed
@junk0612 junk0612 deleted the rip-handmade-parser branch October 19, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junk0612 @yui-knk