Follow-up on development with rbs-inline #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
rbs-inline-follow
branch
2 times, most recently
from
a169fd8 to
0820943
Compare
ydah
commented
Dec 27, 2024
Comment on lines
+141
to
+148
| - name: Check for uncommitted changes | ||
| run: | | ||
| if [ -n "$(git status --porcelain)" ]; then | ||
| echo "Uncommitted changes detected after running rbs-inline." | ||
| echo "Please run 'bundle rake rbs_inline' and commit the changes generated by rbs-inline." >&2 | ||
| exit 1 | ||
| fi | ||
| shell: bash |
There was a problem hiding this comment.
If there is an uncommitted sig/generated/lrama type definition, it fails as follows:
ydah
commented
Dec 27, 2024
|
|
||
| We use [Steep](https://github.com/soutaro/steep) for type checking and [rbs-inline](https://github.com/soutaro/rbs-inline) for type declarations. | ||
|
|
||
| Currently, type signatures are declared in the [sig/lrama](https://github.com/ruby/lrama/blob/master/sig/lrama) directory. However, these files will be replaced with `rbs-inline`. This means type signatures should be written directly in the source code. |
There was a problem hiding this comment.
In the future, once the migration is complete, only this section can be erased.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #490