Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move multiple classes under grammar #53

Merged
merged 7 commits into from
Jul 9, 2023
Merged

Move multiple classes under grammar #53

merged 7 commits into from
Jul 9, 2023

Conversation

alitaso345
Copy link
Contributor

@alitaso345 alitaso345 commented Jul 9, 2023 •
edited
Loading

Summary

  • In Refactor states.rb and grammar.rb #50, multiple classes were separated from grammar.rb, but the file location was not ideal.
  • Multiple classes have been moved to Lrama::Grammar from Lrama.

Changes Made

  • Class files for Code, ErrorToken, Precedence, Printer, Reference, Rule, and Symbol have been relocated to under Lrama::Grammar.
  • Class paths in grammar_spec.rb and parser_spec.rb have been updated to reflect this change.

@alitaso345 alitaso345 changed the title Move each classes under grammar Move multiple classes under grammar Jul 9, 2023
@alitaso345 alitaso345 marked this pull request as ready for review July 9, 2023 01:49
@yui-knk yui-knk merged commit 07dc3ee into ruby:master Jul 9, 2023
9 checks passed
@yui-knk
Copy link
Collaborator

yui-knk commented Jul 9, 2023

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alitaso345 @yui-knk