Updated most of Kernel module methods #1963
Draft
+1,160
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
force-pushed
the
swesterman/24-08-03/Kernel_module_methods
branch
4 times, most recently
from
52248e2
to
c695200
Compare
sampersand
commented
Aug 25, 2024
| @@ -796,7 +796,7 @@ module Kernel : BasicObject | |||
| # If *const* is defined as autoload, the file name to be loaded is replaced with | |||
| # *filename*. If *const* is defined but not as autoload, does nothing. | |||
| # | |||
| def self?.autoload: (interned _module, String filename) -> NilClass | |||
| def self?.autoload: (interned const, path filename) -> nil | |||
There was a problem hiding this comment.
if we ever decide to use const as a keyword we might want to change this to constant?
| @@ -970,7 +969,9 @@ module Kernel : BasicObject | |||
| # For details on `format_string`, see [Format | |||
| # Specifications](rdoc-ref:format_specifications.rdoc). | |||
| # | |||
| def self?.format: (String format, *untyped args) -> String | |||
| def self?.sprintf: (string format, hash[Symbol, untyped] keywords) -> String | |||
There was a problem hiding this comment.
Oddly enough, sprintf only allows positional or keyword arguments, but not both.
| def self?.loop: () { () -> void } -> bot | ||
| | () -> ::Enumerator[nil, bot] | ||
| def self?.loop: () -> Enumerator[nil, bot] | ||
| | () { () -> void } -> untyped |
There was a problem hiding this comment.
untyped instead of bot because you can break out
core/kernel.rbs
Outdated
Comment on lines
1575
to
1583
| def self?.select: ([]?, ?[]?, ?[]?, ?nil) -> bot | ||
| | [R < _ToIO] (Array[R] read, ?[]?, ?[]?, ?nil ) -> [Array[R], [], []] | ||
| | [R < _ToIO] (Array[R] read, []?, []?, Time::_Timeout timeout) -> [Array[R], [], []]? | ||
| | [R < _ToIO, W < _ToIO] (Array[R] read, ?Array[W] write, ?[]?, ?nil ) -> [Array[R], Array[W], []] | ||
| | [R < _ToIO, W < _ToIO] (Array[R] read, Array[W] write, []?, Time::_Timeout timeout) -> [Array[R], Array[W], []]? | ||
| | [R < _ToIO, W < _ToIO, E < _ToIO] (Array[R] read, ?Array[W] write, ?Array[E] error, ?nil ) -> [Array[R], Array[W], Array[E]] | ||
| | [R < _ToIO, W < _ToIO, E < _ToIO] (Array[R] read, Array[W] write, Array[E] error, Time::_Timeout timeout) -> [Array[R], Array[W], Array[E]]? | ||
| | (Array[_ToIO]? read, ?Array[_ToIO]? write, ?Array[_ToIO]? error, ?Time_Timeout? timeout) -> [Array[_ToIO], Array[_ToIO], Array[_ToIO]]? |
There was a problem hiding this comment.
The ?[]? is because you can have empty arrays or nil as options for those arguments; the timeout can only benil, or unspecified though.
| | ('s' | 115, IO | path filename) -> Integer? | ||
| | ('M' | 'A' | 'C' | 77 | 65 | 67, IO | path file) -> Time | ||
| | ('-' | '=' | '<' | '>' | 45 | 60 | 61 | 62, IO | path file1, IO | path file2) -> bool | ||
| | (String | int cmd, IO | path file1, ?IO | path file2) -> (bool | Integer? | Time) |
There was a problem hiding this comment.
this is the "catch all" case, which covers all the other variants.
| @@ -1728,7 +1748,7 @@ module Kernel : BasicObject | |||
| # :experimental | |||
| # : Used for experimental features that may change in future releases. | |||
| # | |||
| def self?.warn: (*_ToS msg, ?uplevel: int?, ?category: Warning::category?) -> nil | |||
| def self?.warn: (*_ToS msgs, ?uplevel: int?, ?category: Warning::category | _ToSym | nil) -> nil | |||
There was a problem hiding this comment.
One of the few places in the stdlib that uses _ToSym and not interend; the return value should be a Warning::category
| @@ -331,7 +331,7 @@ def value(val, type) | |||
| when Types::Variable | |||
| true | |||
| when Types::Literal | |||
| type.literal == val | |||
| defined?(val.==) and type.literal == val | |||
There was a problem hiding this comment.
This is needed for the Kernel#test, as the int variants of the "catch all" variants don't define ==.
| @@ -336,6 +336,27 @@ def break_from_block(value = nil) | |||
| def pass(message = nil) | |||
| assert true, message | |||
| end | |||
|
|
|||
| def assert_send_raises(sig, errclass, object, method, ...) | |||
| # TODO: ensure args match with signature | |||
There was a problem hiding this comment.
TODO: The sig is actually entirely unused currently, and needs to be updated.
sampersand
force-pushed
the
swesterman/24-08-03/Kernel_module_methods
branch
8 times, most recently
from
51a4c8c
to
8bff31f
Compare
sampersand
force-pushed
the
swesterman/24-08-03/Kernel_module_methods
branch
from
8bff31f
to
e4a11f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates most of
Kernel's module methods. Here's some things to note:Complex,Rational,open,rand,select,exec,spawn, andsystemremain. These methods will be addressed in later PRs, but are somewhat complicated, and I wanted to get this PR merged.Kernelmethods: The newassert_send_raisesdoesn't actually validate the signature it's passed (instead, it only validates the raised error).def self?.XXXsyntax is used to indicatemodule_functions. However, it doesn't mark the instance methods as private (it should be equal todef self.XXXandprivate def XXX).loopwith no arguments returns anEnumerator, except theeachmethod doesn't actually pass in any arguments (ieloop.each{|*x,**y,&z| break [x, y, z] }gives you[[], {}, nil). This means theEnumerator[nil, untyped]interface is technically incorrect, as that implies it is given an argument. I've omitted the test, but I'm not sure what to do about it.