Add spec for Proc#dup
#1019
Merged
Add spec for Proc#dup
#1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moozzi
force-pushed
the
add_spec_for_proc_dup
branch
from
f70d0b8 to
e12a895
Compare
core/proc/shared/dup.rb
Outdated
| it "returns an instance of subclass" do | ||
| cl = Class.new(Proc) | ||
|
|
||
| cl.new{}.dup.class.should == cl |
There was a problem hiding this comment.
major: It's a shared example and used for both #dup and #clone methods. It's parametrised with @method instance variable, that may be either :clone or :dup.
So instead of hardcoding the dup method call (cl.new{}.dup) a proper method should be called with send(@method) (you may find a test case above useful).
There was a problem hiding this comment.
ohh.. that makes sense
moozzi
force-pushed
the
add_spec_for_proc_dup
branch
from
e12a895 to
2b8e143
Compare
remove trailing whitespace
moozzi
force-pushed
the
add_spec_for_proc_dup
branch
from
2b8e143 to
4f98b60
Compare
|
Thank you for the specs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1016
New spec for
Proc#dupfrom this issue.