Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call rb_str_set_len while released the GVL. #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't call rb_str_set_len while released the GVL. #88

wants to merge 1 commit into from

Commits on Nov 7, 2024

  1. Only release the GVL where necessary. 

    - Several string manipulation methods were invoked while the GVL was
  released. This is unsafe.
- The mutex protecting multi-threaded access was not covering buffer state
  manipulation, leading to data corruption and out-of-bounds writes.
- Using `rb_str_locktmp` prevents changes to buffer while it's in use.

[Bug #20863]
    @ioquatix
    ioquatix committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2e169ab View commit details
    Browse the repository at this point in the history