Back to nronn #1257
Merged
Back to nronn #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
temporarily deployed
to
bundler-site-back-to-nr-kynogd
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Using the fork released to rubygems.org is what @tnir did initially at #841, but I reverted that at #1021 because:
What was your diagnosis of the problem?
My diagnosis was that ronn-ng has not really got any traction and I decided to move on to nronn in Bundler at rubygems/rubygems#7227.
What is your fix for the problem, implemented in this PR?
My fix is to also migrate to nronn here.
Why did you choose this fix out of the possible options?
I chose this fix because it sounds like the best path going forward.