Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document file option for ruby directive #1291

Merged

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Feb 6, 2024

Feature was implemented in rubygems/rubygems#6876 and documented on the
manpage
but it seems like it makes sense to have on this page as well, as it is the top google result for "gemfile ruby version".

This copy is lifted (and lightly edited) from the manpage source https://github.com/rubygems/rubygems/blob/6bbc8bed344eeaadcbd8dfcc6e20c9e1eb734d96/bundler/lib/bundler/man/gemfile.5.ronn?plain=1#L72-L80

This is already documented on the
[manpage](https://bundler.io/v2.5/man/gemfile.5.html#VERSION-required-)
but it seems like it makes sense to have on this page as well.

Feature was implemented in rubygems/rubygems#6876

This copy is lifted from the manpage source https://github.com/rubygems/rubygems/blob/6bbc8bed344eeaadcbd8dfcc6e20c9e1eb734d96/bundler/lib/bundler/man/gemfile.5.ronn?plain=1#L72-L80
@albertchae albertchae force-pushed the document-ruby-version-file branch from 18fc567 to ffe36cf Compare February 6, 2024 21:34
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this repetition is good!

@olleolleolle olleolleolle merged commit 06fd2f7 into rubygems:master Feb 7, 2024
3 checks passed
@albertchae albertchae deleted the document-ruby-version-file branch February 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants