Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump haml from 5.2.2 to 6.0.4 #935

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 3, 2022

Bumps haml from 5.2.2 to 6.0.4.

Release notes

Sourced from haml's releases.

6.0.1

  • Unescape HTML-safe interpolation on Rails #1084
  • Resurrect Haml 5's AttributeParser.available? for syntax_tree-haml #1085

6.0.0

Haml 6 became 1.7x faster than Haml 5, and it's now faster than Slim and Erubi in this benchmark that was originally written by Slim developers.

$ bundle exec ruby benchmark/slim/run-benchmarks.rb
Calculating -------------------------------------
       erubi v1.11.0    34.595k i/100ms
         slim v4.1.0    30.931k i/100ms
  haml v6.0.0.beta.1    35.621k i/100ms
-------------------------------------------------
       erubi v1.11.0    411.827k (± 0.4%) i/s -      2.076M
         slim v4.1.0    361.660k (± 0.4%) i/s -      1.825M
  haml v6.0.0.beta.1    427.207k (± 0.6%) i/s -      2.137M

Comparison: haml v6.0.0.beta.1: 427206.9 i/s erubi v1.11.0: 411826.6 i/s - 1.04x slower slim v4.1.0: 361659.8 i/s - 1.18x slower

Changes

  • Replace the implementation with Hamlit
    • Haml 6 is about 1.7x faster than Haml 5 in this benchmark.
    • The parser is kept as is, but everything else is replaced.
    • The haml CLI interface was also replaced.
    • The interface of Haml::Engine is changed. Haml::Template is most likely what you need now.
    • Most Haml helpers are removed.
      • Rails:
        • Kept: find_and_reserve, preserve, surround, precede, succeed, capture_haml
        • Removed: block_is_haml?, flatten, haml_concat, haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?, list_of, non_haml, tab_down, tab_up, with_tabs
      • Tilt:
        • Kept: preserve
        • Removed: block_is_haml?, capture_haml, escape_once, find_and_preserve, flatten, haml_concat, haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?, list_of, non_haml, precede, succeed, surround, tab_down, tab_up, with_tabs
    • Only the attributes in Haml::AttributeBuilder::BOOLEAN_ATTRIBUTES are handled as boolean attributes.
    • Some legacy Rails integration is removed.

6.0.0.beta.1

Haml 6 became 1.7x faster than Haml 5, and it's now faster than Slim and Erubi in this benchmark that was originally written by Slim developers.

$ bundle exec ruby benchmark/slim/run-benchmarks.rb
</tr></table> 

... (truncated)

Changelog

Sourced from haml's changelog.

6.0.4

Released on October 2, 2022 (diff).

  • Fix a parse failure of % in attributes #1096
  • Add another fallback from C to Ruby for Wasm.

6.0.3

Released on September 28, 2022 (diff).

  • For Wasm, fallback to Ruby when C extension is not available.

6.0.2

Released on September 28, 2022 (diff).

  • Unescape HTML-safe arguments for surround, succeed, and precede on Rails #1088

6.0.1

Released on September 23, 2022 (diff).

  • Unescape HTML-safe interpolation on Rails #1084
  • Resurrect Haml 5's AttributeParser.available? for syntax_tree-haml #1085

6.0.0

Released on September 21, 2022 (diff).

  • Replace the implementation with Hamlit
    • Haml 6 is about 1.7x faster than Haml 5 in this benchmark.
    • The parser is kept as is, but everything else is replaced.
    • The haml CLI interface was also replaced.
    • The interface of Haml::Engine is changed. Haml::Template is most likely what you need now.
    • Most Haml helpers are removed.
      • Rails:
        • Kept: find_and_reserve, preserve, surround, precede, succeed, capture_haml
        • Removed: block_is_haml?, flatten, haml_concat, haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?, list_of, non_haml, tab_down, tab_up, with_tabs
      • Tilt:
        • Kept: preserve
        • Removed: block_is_haml?, capture_haml, escape_once, find_and_preserve, flatten, haml_concat, haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?,

... (truncated)

Commits
  • d92a5aa Version 6.0.4
  • 4067b1a Suppress a warning from Tilt
  • e3bd326 Fix a crash in StringSplitter
  • 7e31a8e Fork StringSplitter until merged to upstream
  • 1abd830 Fallback to Ruby instead of C ext in util.rb also (#1093)
  • 86a7add Let test depend on compile for CI
  • 7b1bff1 Leave TODO comments about assert_haml
  • 6ee3f12 Rename hamlit tests to haml
  • f9643d6 List up removed helpers
  • ab040ed Version 6.0.3
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 3, 2022
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-dependabot-zp5qog October 3, 2022 08:01 Inactive
Bumps [haml](https://github.com/haml/haml) from 5.2.2 to 6.0.4.
- [Release notes](https://github.com/haml/haml/releases)
- [Changelog](https://github.com/haml/haml/blob/main/CHANGELOG.md)
- [Commits](haml/haml@v5.2.2...v6.0.4)

---
updated-dependencies:
- dependency-name: haml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/haml-6.0.4 branch from 04083d5 to 8640fbc Compare October 3, 2022 08:06
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-dependabot-0d2hbf October 3, 2022 08:06 Inactive
@hsbt
Copy link
Member

hsbt commented Oct 4, 2022

blocked at #918

@olleolleolle
Copy link
Member

@dependabot ignore this major version

@dependabot dependabot bot closed this Oct 4, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2022

OK, I won't notify you about version 6.x.x again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/bundler/haml-6.0.4 branch October 4, 2022 04:06
@olleolleolle
Copy link
Member

(I made an attempt at clarifying, using the ignore this major, well, perhaps it didn't clarify things. We'll see. At least, this PR is not open now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants