Use DatabaseCleaner gem to remove bad test state

[martinemde]

Should fix the regular problem where test state can be left in the database, which causes errors like the following:

ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_api_keys_on_hashed_key"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (779ee17) to head (a468f37).
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5214   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files         430      430           
  Lines        9120     9120           
=======================================
  Hits         8824     8824           
  Misses        296      296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[simi]

Any idea which test left this?

[martinemde]

@simi no, it seems to happen pretty reliably if you interrupt the tests, but running all integration tests on the organizations branch seemed to trigger it.

This isn't just a rare thing for me though, it happens all the time. The ApiKey one has been happening for a while. Even just clearing the database at the start rather than after each test would make a big difference.

[martinemde]

We could remove this and just clear at the start of each run. This would solve the main problem I see.

[simi]

@simi no, it seems to happen pretty reliably if you interrupt the tests, but running all integration tests on the organizations branch seemed to trigger it.

This isn't just a rare thing for me though, it happens all the time. The ApiKey one has been happening for a while. Even just clearing the database at the start rather than after each test would make a big difference.

Do you think it is related to system tests?