-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle array access syntax on strings with emoji #34
Open
jbender
wants to merge
1
commit into
rubymotion-community:master
Choose a base branch
from
jbender:feature/emoji-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,4 +101,33 @@ def last(limit = 1) | |
from(-limit) | ||
end | ||
end | ||
|
||
# Emojis pose a problem for array-like access of a string. If you try to | ||
# grab one register you'll get am error: "You can't cut a surrogate in two in | ||
# an encoding that is not UTF-16 (IndexError)" | ||
# Calling split(''), which splits the string into array of characters, works | ||
# correctly even with emojis. So to make this method work as expected for | ||
# strings, first split it then join. | ||
|
||
# These are the method definitions of String#[]. The first three match the | ||
# method definition of an array so only apply the patch if the arguments | ||
# look like that. | ||
# - str[index] => new_str or nil | ||
# - str[start, length] => new_str or nil | ||
# - str[range] => new_str or nil | ||
# - str[regexp] => new_str or nil | ||
# - str[regexp, capture] => new_str or nil | ||
# - str[match_str] => new_str or nil | ||
alias_method :bracket_access_original, :[] | ||
|
||
def [](*args) | ||
unless args[0].is_a?(Numeric) || args[0].is_a?(Range) | ||
return bracket_access_original(*args) | ||
end | ||
|
||
# Could be nil, string (one character), or array of characters | ||
characters = split('')[*args] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a test for each of those three cases? |
||
|
||
characters.is_a?(Array) ? characters.join : characters | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "you'll get am error"